fix: remove DOM side effects from React19Dispatcher render()#264
Closed
fix: remove DOM side effects from React19Dispatcher render()#264
Conversation
…effects from render Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update for React 19 support and TypeScript cleanup
fix: remove DOM side effects from React19Dispatcher render()
Mar 3, 2026
Owner
|
@copilot you have merge conflicts |
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Contributor
Author
Owner
|
@copilot mege conflicts still? rebase this PR and see if still relevant |
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Contributor
Author
Synced in 9f7c45e. I can't rebase (no force push available), but I've updated the 2 remaining files ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyNonHostedAttributes()tocomponentDidMount(keep incomponentDidUpdate)init()method and its call fromrender()The original render side-effect fix is already incorporated in the base branch. This PR now has zero diff against v3.0.0 and can be closed as resolved.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.